feat: t0112 cors testing #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsenta
commented
May 18, 2023
| } | ||
|
|
||
| test.Run(t, tests) | ||
| } |
There was a problem hiding this comment.
@lidel I believe this is all we want to port from t0112, since the rest is related to the API, but please let me know if we missed something
Sharness test in kubo: https://github.com/ipfs/kubo/blob/da28fbc65a2e0f1ce59f9923823326ae2bc4f713/test/sharness/t0112-gateway-cors.sh
20 tasks
galargh
approved these changes
May 22, 2023
laurentsenta
force-pushed
the
feat/t0112_cors
branch
from
32364d7
to
8d04e4e
Compare
lidel
approved these changes
May 25, 2023
There was a problem hiding this comment.
Thank you @laurentsenta ❤️
lgtm, cosmetics below, but fine to merge
Co-authored-by: Marcin Rataj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IsUniquewhich was implicit beforeHas(strings), which makes a set comparisonCheckNotto take any type of Check and return the negation